Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Do not launch Spyder if installing in CI or batch/silent mode (Installers) #22876

Merged
merged 5 commits into from
Nov 7, 2024
Merged

PR: Do not launch Spyder if installing in CI or batch/silent mode (Installers) #22876

merged 5 commits into from
Nov 7, 2024

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Nov 6, 2024 •
edited
Loading

Description of Changes

Installing Spyder using our conda-based installers from the command-line will now recognize two environment variables: CI or INSTALLER_UNATTENDED. If either are set to 1, Spyder will not be launched upon completing the installation.

macOS .pkg installers do not receive command-line environment variables, so CI and INSTALLER_UNATTENDED will not have any affect. However, COMMAND_LINE_INSTALL is unique to macOS .pkg installers and set when launched from the command-line, so this variable is leveraged to refrain from launching Spyder in this circumstance.

Note that for the next constructor release (>3.9.3, see conda/constructor#885), INSTALLER_UNATTENDED is automatically set to 1 if .sh or .exe installers are run in batch mode (-b for .sh installers) or silent mode (/S for .exe installers).

Examples

INSTALLER_UNATTENDED=1 bash Spyder-Linux-x86_64.sh -b
INSTALLER_UNATTENDED=1 start /wait Spyder-Windows-x86_64.exe /InstallationType=JustMe /S
installer -pkg Spyder-macOS-x86_64.pkg -target CurrentUserHomeDirectory

Issue(s) Resolved

Fixes #22730

@ccordoba12 ccordoba12 added this to the v6.1.0 milestone Nov 6, 2024
@mrclary mrclary modified the milestones: v6.1.0, v6.0.3 Nov 6, 2024
@mrclary mrclary marked this pull request as ready for review November 6, 2024 21:57
@mrclary mrclary requested a review from ccordoba12 November 6, 2024 21:58
@mrclary
Copy link
Contributor Author

mrclary commented Nov 6, 2024

@ccordoba12, we can include this in 6.0.3 since this does not require an update to constructor. When constructor is updated, this feature will smoothly transition and users will no longer need to preface the command-line install command with INSTALLER_UNATTENDED=1.

@ccordoba12
Copy link
Member

ccordoba12 commented Nov 7, 2024 •
edited
Loading

we can include this in 6.0.3 since this does not require an update to constructor

Ok, I think that's a good idea.

When constructor is updated, this feature will smoothly transition and users will no longer need to preface the command-line install command with INSTALLER_UNATTENDED=1

Agreed. But to make this feature more discoverable, could you add a new entry to the FAQ page in our docs to describe how to install Spyder in silent mode?

You can add a simple text about that and copy/paste the commands you posted in the OP. Then you could update that entry when 6.1 is released to delete INSTALLER_UNATTENDED=1 from the Windows and Linux commands.

ccordoba12
ccordoba12 reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tiny suggestions for you @mrclary, the rest looks good to me.

installers-conda/resources/post-install.bat Outdated Show resolved Hide resolved
installers-conda/resources/post-install.sh Outdated Show resolved Hide resolved
mrclary and others added 5 commits November 7, 2024 08:13
@mrclary
Do not launch Spyder if installing in CI or batch/silent mode.
e6082f9 
With conda/constructor#885, batch/silent mode installs will automatically set INSTALLER_UNATTENDED environment variable accessible by user scripts. Until the next constructor version (>3.9.3) users may set either CI=1 or INSTALLER_UNATTENDED=1 at the commandline.
@mrclary
Ensure that post-install.bat stdout/err is sent to install.log.
eb841ee
@mrclary
Do not launch Spyder if macOS pkg installer is run from command line.
c941051
@mrclary
Appropriately trigger workflows on change of installer_test.sh
2fe8ccd
@mrclary @ccordoba12
Apply suggestions from code review
3940d5d 
Co-authored-by: Carlos Cordoba <[email protected]>
@mrclary
Copy link
Contributor Author

mrclary commented Nov 7, 2024

could you add a new entry to the FAQ page in our docs to describe how to install Spyder in silent mode?

I'm unable to make any commits to my local spyder-docs repository. I get a lot of npm errors. I suspect that the pre-commit hooks will not run on macOS for some reason.

stdout 
(spy-docs) >> nox -s lint
nox > Running session lint
nox > Session lint was successful.
nox > Running session _execute
nox > Re-using existing virtual environment at .nox/_execute.
nox > pre-commit run --all
[INFO] Installing environment for https://github.com/eslint/eslint.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/Users/rclary/.cache/pre-commit/repoch9k28y1/node_env-system/bin/node', '/usr/local/bin/npm', 'install', '--include=dev', '--include=prod', '--ignore-prepublish', '--no-progress', '--no-save')
return code: 1
stdout: (none)
stderr:
    (node:71216) ExperimentalWarning: CommonJS module /usr/local/lib/node_modules/npm/node_modules/debug/src/node.js is loading ES Module /usr/local/lib/node_modules/npm/node_modules/supports-color/index.js using require().
    Support for loading ES Module in require() is an experimental feature and might change at any time
    (Use `node --trace-warnings ...` to show where the warning was created)
    npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
    npm warn deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
    npm warn deprecated [email protected]: This functionality has been moved to @npmcli/fs
    npm warn deprecated [email protected]: This package is no longer supported. Please use @npmcli/package-json instead.
    npm warn deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
    npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
    npm warn deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
    npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
    npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
    npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
    npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
    npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
    npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
    npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
    npm warn deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead
    npm warn deprecated [email protected]: This package is no longer supported.
    npm warn deprecated [email protected]: 16.1.1
    npm error code 1
    npm error path /Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/re2
    npm error command failed
    npm error command sh -c install-from-cache --artifact build/Release/re2.node --host-var RE2_DOWNLOAD_MIRROR --skip-path-var RE2_DOWNLOAD_SKIP_PATH --skip-ver-var RE2_DOWNLOAD_SKIP_VER || node-gyp -j max rebuild
    npm error Trying https://github.com/uhop/node-re2/releases/download/1.21.4/darwin-x64-131.br ...
    npm error Trying https://github.com/uhop/node-re2/releases/download/1.21.4/darwin-x64-131.gz ...
    npm error Building locally ...
    npm error
    npm error > [email protected] rebuild
    npm error > node-gyp -j max rebuild
    npm error
    npm error
    npm error   CXX(target) Release/obj.target/re2/lib/addon.o
    npm error   CXX(target) Release/obj.target/re2/lib/accessors.o
    npm error   CXX(target) Release/obj.target/re2/lib/util.o
    npm error   CXX(target) Release/obj.target/re2/lib/new.o
    npm error   CXX(target) Release/obj.target/re2/lib/exec.o
    npm error   CXX(target) Release/obj.target/re2/lib/test.o
    npm error   CXX(target) Release/obj.target/re2/lib/match.o
    npm error   CXX(target) Release/obj.target/re2/lib/search.o
    npm error   CXX(target) Release/obj.target/re2/lib/to_string.o
    npm error   CXX(target) Release/obj.target/re2/vendor/re2/re2/compile.o
    npm error   CXX(target) Release/obj.target/re2/vendor/re2/re2/dfa.o
    npm error   CXX(target) Release/obj.target/re2/vendor/re2/re2/filtered_re2.o
    npm error   CXX(target) Release/obj.target/re2/vendor/re2/re2/bitmap256.o
    npm error   CXX(target) Release/obj.target/re2/vendor/re2/re2/bitstate.o
    npm error   CXX(target) Release/obj.target/re2/lib/split.o
    npm error   CXX(target) Release/obj.target/re2/lib/replace.o
    npm error
    npm error   CXX(target) Release/obj.target/re2/lib/addon.o
    npm error   CXX(target) Release/obj.target/re2/lib/accessors.o
    npm error   CXX(target) Release/obj.target/re2/lib/util.o
    npm error   CXX(target) Release/obj.target/re2/lib/new.o
    npm error   CXX(target) Release/obj.target/re2/lib/exec.o
    npm error   CXX(target) Release/obj.target/re2/lib/test.o
    npm error   CXX(target) Release/obj.target/re2/lib/match.o
    npm error   CXX(target) Release/obj.target/re2/lib/search.o
    npm error   CXX(target) Release/obj.target/re2/vendor/re2/re2/bitstate.o
    npm error   CXX(target) Release/obj.target/re2/lib/split.o
    npm error   CXX(target) Release/obj.target/re2/lib/to_string.o
    npm error   CXX(target) Release/obj.target/re2/vendor/re2/re2/dfa.o
    npm error   CXX(target) Release/obj.target/re2/vendor/re2/re2/compile.o
    npm error   CXX(target) Release/obj.target/re2/lib/replace.o
    npm error   CXX(target) Release/obj.target/re2/vendor/re2/re2/bitmap256.o
    npm error   CXX(target) Release/obj.target/re2/vendor/re2/re2/filtered_re2.o
    npm error gyp info it worked if it ends with ok
    npm error gyp info using [email protected]
    npm error gyp info using [email protected] | darwin | x64
    npm error gyp info find Python using Python version 3.13.0 found at "/Users/rclary/Documents/Repos/Spyder-IDE/spyder-docs/.nox/_execute/bin/python3"
    npm error gyp info spawn /Users/rclary/Documents/Repos/Spyder-IDE/spyder-docs/.nox/_execute/bin/python3
    npm error gyp info spawn args [
    npm error gyp info spawn args '/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/node-gyp/gyp/gyp_main.py',
    npm error gyp info spawn args 'binding.gyp',
    npm error gyp info spawn args '-f',
    npm error gyp info spawn args 'make',
    npm error gyp info spawn args '-I',
    npm error gyp info spawn args '/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/re2/build/config.gypi',
    npm error gyp info spawn args '-I',
    npm error gyp info spawn args '/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/node-gyp/addon.gypi',
    npm error gyp info spawn args '-I',
    npm error gyp info spawn args '/Users/rclary/Library/Caches/node-gyp/23.1.0/include/node/common.gypi',
    npm error gyp info spawn args '-Dlibrary=shared_library',
    npm error gyp info spawn args '-Dvisibility=default',
    npm error gyp info spawn args '-Dnode_root_dir=/Users/rclary/Library/Caches/node-gyp/23.1.0',
    npm error gyp info spawn args '-Dnode_gyp_dir=/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/node-gyp',
    npm error gyp info spawn args '-Dnode_lib_file=/Users/rclary/Library/Caches/node-gyp/23.1.0/<(target_arch)/node.lib',
    npm error gyp info spawn args '-Dmodule_root_dir=/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/re2',
    npm error gyp info spawn args '-Dnode_engine=v8',
    npm error gyp info spawn args '--depth=.',
    npm error gyp info spawn args '--no-parallel',
    npm error gyp info spawn args '--generator-output',
    npm error gyp info spawn args 'build',
    npm error gyp info spawn args '-Goutput_dir=.'
    npm error gyp info spawn args ]
    npm error gyp info spawn make
    npm error gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build', '--jobs', 16 ]
    npm error In file included from ../lib/to_string.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error In file included from ../lib/addon.cc:1:
    npm error ../lib/./wrapped_re2.h    3 | #i:3:10:n cfatal error: 'string' file not found
    npm error     3 | #ludinclude <string>
    npm error       |          ^~~~~~~~
    npm error e <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/util.cc:1:
    npm error In file included from ../lib/./util.h:3:
    npm error ../lib/././wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/new.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/accessors.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/search.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/match.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/exec.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/test.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../vendor/re2/re2/filtered_re2.cc:5:
    npm error ../vendor/re2/re2/filtered_re2.h:24:10: fatal error: 'memory' file not found
    npm error    24 | #include <memory>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/replace.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/split.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error ../vendor/re2/re2/compile.cc:14:10: fatal error: 'string' file not found
    npm error    14 | #include <string>
    npm error       |          ^~~~~~~~
    npm error ../vendor/re2/re2/bitstate.cc:24:10: fatal error: 'limits' file not found
    npm error    24 | #include <limits>
    npm error       |          ^~~~~~~~
    npm error ../vendor/re2/re2/dfa.cc:29:10: fatal error: 'algorithm' file not found
    npm error    29 | #include <algorithm>
    npm error       |          ^~~~~~~~~~~
    npm error In file included from ../vendor/re2/re2/bitmap256.cc:5:
    npm error In file included from ../vendor/re2/re2/bitmap256.h:11:
    npm error In file included from ../vendor/abseil-cpp/absl/log/absl_check.h:38:
    npm error In file included from ../vendor/abseil-cpp/absl/log/internal/check_impl.h:18:
    npm error In file included from ../vendor/abseil-cpp/absl/base/optimization.h:27:
    npm error ../vendor/abseil-cpp/absl/base/config.h:56:10: fatal error: 'cstddef' file not found
    npm error    56 | #include <cstddef>
    npm error       |          ^~~~~~~~~
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/vendor/re2/re2/bitmap256.o] Error 1
    npm error make: *** Waiting for unfinished jobs....
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/vendor/re2/re2/bitstate.o] Error 1
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/vendor/re2/re2/filtered_re2.o] Error 1
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/vendor/re2/re2/dfa.o] Error 1
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/vendor/re2/re2/compile.o] Error 1
    npm error 1 error generated.
    npm error 1 error generated.
    npm error 1 error generated.
    npm error 1 error generated.
    npm error 1 error generated.
    npm error 1 error generated.
    npm error 1 error generated.
    npm error 1 error generated.
    npm error 1 error generated.
    npm error 1 error generated.
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/lib/search.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/util.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/addon.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/to_string.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/split.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/replace.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/match.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/test.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/new.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/exec.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/accessors.o] Error 1
    npm error gyp ERR! build error 
    npm error gyp ERR! stack Error: `make` failed with exit code: 2
    npm error gyp ERR! stack at ChildProcess.<anonymous> (/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/node-gyp/lib/build.js:216:23)
    npm error gyp ERR! System Darwin 23.6.0
    npm error gyp ERR! command "/usr/local/Cellar/node/23.1.0_1/bin/node" "/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/.bin/node-gyp" "-j" "max" "rebuild"
    npm error gyp ERR! cwd /Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/re2
    npm error gyp ERR! node -v v23.1.0
    npm error gyp ERR! node-gyp -v v10.2.0
    npm error gyp ERR! not ok 
    npm error node:internal/process/promises:392
    npm error       new UnhandledPromiseRejection(reason);
    npm error       ^
    npm error
    npm error UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "1".
    npm error     at throwUnhandledRejectionsMode (node:internal/process/promises:392:7)
    npm error     at processPromiseRejections (node:internal/process/promises:475:17)
    npm error     at process.processTicksAndRejections (node:internal/process/task_queues:106:32) {
    npm error   code: 'ERR_UNHANDLED_REJECTION'
    npm error }
    npm error
    npm error Node.js v23.1.0
    npm error gyp info it worked if it ends with ok
    npm error gyp info using [email protected]
    npm error gyp info using [email protected] | darwin | x64
    npm error gyp info find Python using Python version 3.13.0 found at "/Users/rclary/Documents/Repos/Spyder-IDE/spyder-docs/.nox/_execute/bin/python3"
    npm error gyp info spawn /Users/rclary/Documents/Repos/Spyder-IDE/spyder-docs/.nox/_execute/bin/python3
    npm error gyp info spawn args [
    npm error gyp info spawn args '/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/node-gyp/gyp/gyp_main.py',
    npm error gyp info spawn args 'binding.gyp',
    npm error gyp info spawn args '-f',
    npm error gyp info spawn args 'make',
    npm error gyp info spawn args '-I',
    npm error gyp info spawn args '/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/re2/build/config.gypi',
    npm error gyp info spawn args '-I',
    npm error gyp info spawn args '/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/node-gyp/addon.gypi',
    npm error gyp info spawn args '-I',
    npm error gyp info spawn args '/Users/rclary/Library/Caches/node-gyp/23.1.0/include/node/common.gypi',
    npm error gyp info spawn args '-Dlibrary=shared_library',
    npm error gyp info spawn args '-Dvisibility=default',
    npm error gyp info spawn args '-Dnode_root_dir=/Users/rclary/Library/Caches/node-gyp/23.1.0',
    npm error gyp info spawn args '-Dnode_gyp_dir=/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/node-gyp',
    npm error gyp info spawn args '-Dnode_lib_file=/Users/rclary/Library/Caches/node-gyp/23.1.0/<(target_arch)/node.lib',
    npm error gyp info spawn args '-Dmodule_root_dir=/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/re2',
    npm error gyp info spawn args '-Dnode_engine=v8',
    npm error gyp info spawn args '--depth=.',
    npm error gyp info spawn args '--no-parallel',
    npm error gyp info spawn args '--generator-output',
    npm error gyp info spawn args 'build',
    npm error gyp info spawn args '-Goutput_dir=.'
    npm error gyp info spawn args ]
    npm error gyp info spawn make
    npm error gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build', '--jobs', 16 ]
    npm error In file included from ../lib/addon.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/accessors.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/util.cc:1:
    npm error In file included from ../lib/./util.h:3:
    npm error ../lib/././wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/new.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/exec.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/search.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/match.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/test.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/split.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/to_string.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error ../vendor/re2/re2/bitstate.cc:24:10: fatal error: 'limits' file not found
    npm error    24 | #include <limits>
    npm error       |          ^~~~~~~~
    npm error In file included from ../vendor/re2/re2/filtered_re2.cc:5:
    npm error ../vendor/re2/re2/filtered_re2.h:24:10: fatal error: 'memory' file not found
    npm error    24 | #include <memory>
    npm error       |          ^~~~~~~~
    npm error In file included from ../lib/replace.cc:1:
    npm error ../lib/./wrapped_re2.h:3:10: fatal error: 'string' file not found
    npm error     3 | #include <string>
    npm error       |          ^~~~~~~~
    npm error ../vendor/re2/re2/compile.cc:14:10: fatal error: 'string' file not found
    npm error    14 | #include <string>
    npm error       |          ^~~~~~~~
    npm error ../vendor/re2/re2/dfa.cc:29:10: fatal error: 'algorithm' file not found
    npm error    29 | #include <algorithm>
    npm error       |          ^~~~~~~~~~~
    npm error In file included from ../vendor/re2/re2/bitmap256.cc:5:
    npm error In file included from ../vendor/re2/re2/bitmap256.h:11:
    npm error In file included from ../vendor/abseil-cpp/absl/log/absl_check.h:38:
    npm error In file included from ../vendor/abseil-cpp/absl/log/internal/check_impl.h:18:
    npm error In file included from ../vendor/abseil-cpp/absl/base/optimization.h:27:
    npm error ../vendor/abseil-cpp/absl/base/config.h:56:10: fatal error: 'cstddef' file not found
    npm error    56 | #include <cstddef>
    npm error       |          ^~~~~~~~~
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/vendor/re2/re2/bitmap256.o] Error 1
    npm error make: *** Waiting for unfinished jobs....
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/vendor/re2/re2/bitstate.o] Error 1
    npm error 1 error generated.
    npm error 1 error generated.
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/lib/accessors.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/util.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/addon.o] Error 1
    npm error 1 error generated.
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/lib/new.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/exec.o] Error 1
    npm error 1 error generated.
    npm error 1 error generated.
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/lib/search.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/test.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/match.o] Error 1
    npm error 1 error generated.
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/lib/to_string.o] Error 1
    npm error make: *** [Release/obj.target/re2/lib/split.o] Error 1
    npm error 1 error generated.
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/lib/replace.o] Error 1
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/vendor/re2/re2/dfa.o] Error 1
    npm error make: *** [Release/obj.target/re2/vendor/re2/re2/filtered_re2.o] Error 1
    npm error 1 error generated.
    npm error make: *** [Release/obj.target/re2/vendor/re2/re2/compile.o] Error 1
    npm error gyp ERR! build error 
    npm error gyp ERR! stack Error: `make` failed with exit code: 2
    npm error gyp ERR! stack at ChildProcess.<anonymous> (/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/node-gyp/lib/build.js:216:23)
    npm error gyp ERR! System Darwin 23.6.0
    npm error gyp ERR! command "/usr/local/Cellar/node/23.1.0_1/bin/node" "/Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/.bin/node-gyp" "-j" "max" "rebuild"
    npm error gyp ERR! cwd /Users/rclary/.cache/pre-commit/repoch9k28y1/node_modules/re2
    npm error gyp ERR! node -v v23.1.0
    npm error gyp ERR! node-gyp -v v10.2.0
    npm error gyp ERR! not ok
    npm error A complete log of this run can be found in: /Users/rclary/.npm/_logs/2024-11-07T17_12_14_090Z-debug-0.log
Check the log at /Users/rclary/.cache/pre-commit/pre-commit.log
nox > Command pre-commit run --all failed with exit code 3
nox > Session _execute failed.
nox > Ran multiple sessions:
nox > * lint: success
nox > * _execute: failed

@mrclary
Copy link
Contributor Author

mrclary commented Nov 7, 2024

It also seems that we need to update the docs for 6.0 as well.

@ccordoba12
Copy link
Member

I'm unable to make any commits to my local spyder-docs repository. I get a lot of npm errors. I suspect that the pre-commit hooks will not run on macOS for some reason.

Please open a new issue about that in Spyder-docs and assign it to CAM.

It also seems that we need to update the docs for 6.0 as well.

Right, we can only add the FAQ entry I mentioned once we update the docs for 6.0

ccordoba12
ccordoba12 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 changed the title PR: Do not launch Spyder if installing in CI or batch/silent mode. PR: Do not launch Spyder if installing in CI or batch/silent mode (Installers) Nov 7, 2024
@ccordoba12 ccordoba12 merged commit 0f68958 into spyder-ide:master Nov 7, 2024
27 checks passed
@ccordoba12
Copy link
Member

@meeseeksdev please backport to 6.x

@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Nov 7, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 0f689585cb580a9e9f039048fcfdc1c79de673a4
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #22876: PR: Do not launch Spyder if installing in CI or batch/silent mode (Installers)'
  1. Push to a named branch:
git push YOURFORK 6.x:auto-backport-of-pr-22876-on-6.x
  1. Create a PR against branch 6.x, I would have named this PR:

"Backport PR #22876 on branch 6.x (PR: Do not launch Spyder if installing in CI or batch/silent mode (Installers))"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

ccordoba12 added a commit to ccordoba12/spyder that referenced this pull request Nov 7, 2024
@ccordoba12
Backport PR spyder-ide#22876: PR: Do not launch Spyder if installing …
fec8aba 
…in CI or batch/silent mode (Installers)
ccordoba12 added a commit that referenced this pull request Nov 7, 2024
@ccordoba12
Backport PR #22876 on branch 6.x (PR: Do not launch Spyder if install…
07e8f52 
…ing in CI or batch/silent mode (Installers)) (#22893)
@mrclary mrclary deleted the no-launch-spyder branch November 7, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@mrclary mrclary

Labels
Installers type:Enhancement
Projects
None yet
Milestone
v6.0.3
Development

Successfully merging this pull request may close these issues.

Silent install automatically starts the application in Spyder 6
2 participants
@mrclary @ccordoba12